linux-kernel - RE: [PATCH] crypto: qat - fix adf_dbgfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2023 15:39:38 +0000
From:   "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "Muszynski, Damian" <damian.muszynski@...el.com>
CC:     Arnd Bergmann <arnd@...db.de>, qat-linux <qat-linux@...el.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
Subject: RE: [PATCH] crypto: qat - fix adf_dbgfs_exit() typo

Thanks Arnd.
I already sent the same fix a few days ago: https://patchwork.kernel.org/project/linux-crypto/patch/20230603082853.44631-1-giovanni.cabiddu@intel.com/

-- 
Giovanni

-----Original Message-----
From: Arnd Bergmann <arnd@...nel.org> 
Sent: Monday, June 5, 2023 3:45 PM
To: Cabiddu, Giovanni <giovanni.cabiddu@...el.com>; Herbert Xu <herbert@...dor.apana.org.au>; David S. Miller <davem@...emloft.net>; Muszynski, Damian <damian.muszynski@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>; qat-linux <qat-linux@...el.com>; linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH] crypto: qat - fix adf_dbgfs_exit() typo

From: Arnd Bergmann <arnd@...db.de>

The stub function uses a different name from the normal one:

drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]

Rename the function to match the normal one.

Fixes: 9260db6640a61 ("crypto: qat - move dbgfs init to separate file")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
index 1d64ad1a00374..e0cb2c2a2ed0b 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
@@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)  {  }

-static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev)
+static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
 {
 }
 #endif
--
2.39.2