linux-kernel - Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZH4IPJuPoX3gi5Ga@smile.fi.intel.com>
Date:   Mon, 5 Jun 2023 19:07:24 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Lee Jones <lee@...nel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>, Helge Deller <deller@....de>
Subject: Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API

On Mon, Mar 20, 2023 at 01:54:26PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 17, 2023 at 09:53:40PM +0100, Linus Walleij wrote:
> > On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > 
> > > The of_gpio.h is going to be removed. In preparation of that convert
> > > the driver to the agnostic API.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > Thanks for fixing this Andy!
> > 
> > > -#if !IS_ENABLED(CONFIG_LCD_HX8357)
> > > +#if IS_ENABLED(CONFIG_LCD_HX8357)
> > >                 /*
> > >                  * Himax LCD controllers used incorrectly named
> > >                  * "gpios-reset" property and also specified wrong
> > > @@ -452,7 +452,7 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np,
> > >                  */
> > >                 const char *compatible;
> > >         } gpios[] = {
> > > -#if !IS_ENABLED(CONFIG_LCD_HX8357)
> > > +#if IS_ENABLED(CONFIG_LCD_HX8357)
> > >                 /* Himax LCD controllers used "gpios-reset" */
> > >                 { "reset",      "gpios-reset",  "himax,hx8357" },
> > >                 { "reset",      "gpios-reset",  "himax,hx8369" },
> > 
> > Eh what happened here .. it's even intuitively wrong.
> 
> I believe it had to be something  like
> 
> 	#if 0 && IS_ENABLED()
> 
> to show that this change is for the future.
> Currently it does something unneeded for the kernels with that option off.
> 
> > I would add
> > Fixes: fbbbcd177a27 ("gpiolib: of: add quirk for locating reset lines
> > with legacy bindings")
> 
> I'm not sure. But it's fine, I can add it. Just want to double confirm
> you really want this Fixes tag.
> 
> > It wasn't used until now it seems so not a regression and no
> > need for a separate patch.
> 
> Exactly why I'm not sure about the tag :-)
> 
> > Other than that it looks correct.
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Thank you!

Lee, is anything I can do here to move this forward?

-- 
With Best Regards,
Andy Shevchenko