linux-kernel - Re: [PATCH 2/2] drm/amd/display: mark dml314's UseMinimumDCFCLK() as noinline_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 10:02:44 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>
Cc:     amd-gfx@...ts.freedesktop.org, Tom Rix <trix@...hat.com>,
        llvm@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
        Maíra Canal <mairacanal@...eup.net>,
        Jun Lei <Jun.Lei@....com>, Charlene Liu <Charlene.Liu@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Leo Li <sunpeng.li@....com>,
        Nathan Chancellor <nathan@...nel.org>,
        Paul Hsieh <Paul.Hsieh@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org,
        Christian König <christian.koenig@....com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>
Subject: Re: [PATCH 2/2] drm/amd/display: mark dml314's UseMinimumDCFCLK() as noinline_for_stack

Series is:
Acked-by: Alex Deucher <alexander.deucher@....com>

On Mon, Jun 5, 2023 at 2:30 PM Hamza Mahfooz <hamza.mahfooz@....com> wrote:
>
> clang reports:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:3892:6: error: stack frame size (2632) exceeds limit (2048) in 'dml314_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than]
>  3892 | void dml314_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib)
>       |      ^
> 1 error generated.
>
> So, since UseMinimumDCFCLK() consumes a lot of stack space, mark it as
> noinline_for_stack to prevent it from blowing up
> dml314_ModeSupportAndSystemConfigurationFull()'s stack size.
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
> ---
>  .../gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
> index 27b83162ae45..1532a7e0ed6c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
> @@ -7061,7 +7061,7 @@ static double CalculateUrgentLatency(
>         return ret;
>  }
>
> -static void UseMinimumDCFCLK(
> +static noinline_for_stack void UseMinimumDCFCLK(
>                 struct display_mode_lib *mode_lib,
>                 int MaxPrefetchMode,
>                 int ReorderingBytes)
> --
> 2.40.1
>