linux-kernel - RE: [PATCH v1] make AUXILIARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 14:50:21 +0000
From:   Moti Haimovski <mhaimovski@...ana.ai>
To:     Conor Dooley <conor.dooley@...rochip.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "david.m.ertman@...el.com" <david.m.ertman@...el.com>,
        "ogabbay@...nel.org" <ogabbay@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1] make AUXILIARY_BUS config selection clearer

Hi Conor,
 Noting is wrong with the drivers 😊

I've stumbled that issue when trying to figure-out how to manipulate the auxiliary-bus selection
Via "make menuconfig"
The issue is that with the current Kconfig when you run " make menuconfig" and enter the
Device Drivers --->     Generic Driver Options --->   Sub-menu then there is no mentioning of
 the Auxiliary bus although it is the first entry in drivers/base/Kconfig that this menu is presenting.
So, the user has no idea that this option exists and no way to manipulate it via menconfig.
My commit makes this option "visible" by adding the short description in the "bool" line
and , while at it, adding a short description for the sake of future generations.
No functionality nor default values were altered.

Hope this answers your question
 Moti H

> -----Original Message-----
> From: Conor Dooley <conor.dooley@...rochip.com>
> Sent: Tuesday, 6 June 2023 16:48
> To: Moti Haimovski <mhaimovski@...ana.ai>
> Cc: gregkh@...uxfoundation.org; david.m.ertman@...el.com;
> ogabbay@...nel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
> 
> Hey Moti,
> 
> On Tue, Jun 06, 2023 at 04:35:28PM +0300, Moti Haimovski wrote:
> > Add a display string and a help section to the config AUXILIARY_BUS
> > section under the "Generic Driver Options" menu in order to make its
> > selection clearer.
> 
> I am a wee bit confused, since it is not explicitly mentioned here, why is this
> now going to be user visible/selectable? What was wrong with the drivers
> that needed it selecting it?
> 
> Thanks,
> Conor.
> 
> >
> > Signed-off-by: Moti Haimovski <mhaimovski@...ana.ai>
> > ---
> >  drivers/base/Kconfig | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index
> > 6f04b831a5c0..e1caac1d9a58 100644
> > --- a/drivers/base/Kconfig
> > +++ b/drivers/base/Kconfig
> > @@ -2,7 +2,16 @@
> >  menu "Generic Driver Options"
> >
> >  config AUXILIARY_BUS
> > -	bool
> > +	bool "Support for auxiliary bus"
> > +	help
> > +	  The auxiliary bus driver provides a way to export an interface
> > +	  for another subsystem to drive, implement a common intersection
> > +	  of functionality or split a function into child-devices
> > +	  representing sub-domains of functionality where each auxiliary
> > +	  device represents a part of its parent functionality (usually)
> > +	  driven by another driver.
> > +
> > +	  If unsure, say Y.
> >
> >  config UEVENT_HELPER
> >  	bool "Support for uevent helper"
> > --
> > 2.25.1
> >