[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2023 17:10:13 +0100
From: Mark Brown <broonie@...nel.org>
To: Takashi Iwai <tiwai@...e.de>
Cc: Shenghao Ding <13916275206@....com>, devicetree@...r.kernel.org,
krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
lgirdwood@...il.com, perex@...ex.cz,
pierre-louis.bossart@...ux.intel.com, kevin-lu@...com,
shenghao-ding@...com, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, x1077012@...com, peeyush@...com,
navada@...com, gentuser@...il.com, Ryan_Chu@...tron.com,
Sam_Wu@...tron.com
Subject: Re: [PATCH v4 5/6] ALSA: hda/tas2781: Add tas2781 HDA driver
On Tue, Jun 06, 2023 at 06:08:51PM +0200, Takashi Iwai wrote:
> Shenghao Ding wrote:
> > + //Lenovo devices
> > + if ((subid == 0x387d) || (subid == 0x387e) || (subid == 0x3881)
> > + || (subid == 0x3884) || (subid == 0x3886) || (subid == 0x38a7)
> > + || (subid == 0x38a8) || (subid == 0x38ba) || (subid == 0x38bb)
> > + || (subid == 0x38be) || (subid == 0x38bf) || (subid == 0x38c3)
> > + || (subid == 0x38cb) || (subid == 0x38cd))
> > + tas_priv->catlog_id = LENOVO;
> > + else
> > + tas_priv->catlog_id = OTHERS;
> Hmm, I don't like checking subid here, but we can live with it for
> now...
Might be more idiomatically/neatly written as a switch statement though.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists