linux-kernel - Re: [PATCH v9 6/8] drm: Remove usage of deprecated DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 06 Jun 2023 22:44:31 +0530
From:   Siddh Raman Pant <code@...dh.me>
To:     "Laurent Pinchart" <laurent.pinchart@...asonboard.com>
Cc:     "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
        "Maxime Ripard" <mripard@...nel.org>,
        "Thomas Zimmermann" <tzimmermann@...e.de>,
        "David Airlie" <airlied@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "Andrzej Hajda" <andrzej.hajda@...el.com>,
        "Neil Armstrong" <neil.armstrong@...aro.org>,
        "Robert Foss" <rfoss@...nel.org>,
        "Jonas Karlman" <jonas@...boo.se>,
        "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Jani Nikula" <jani.nikula@...ux.intel.com>,
        "dri-devel" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "Suraj Upadhyay" <usuraj35@...il.com>
Subject: Re: [PATCH v9 6/8] drm: Remove usage of deprecated DRM_DEBUG

On Tue, 06 Jun 2023 20:27:06 +0530, Laurent Pinchart wrote:
> Hi Siddh,
> 
> Thank you for the patch.

Anytime :)

> >       if (!ctx_entry) {
> > -             DRM_DEBUG("out of memory\n");
> > +             drm_dbg_core(dev, "out of memory\n");
> 
> This message could also be dropped.

Okay.

> > -     DRM_DEBUG("\n");
> > +     drm_dbg_core(dev, "\n");
> 
> This message seems of dubious value :-) Maybe you could drop it in a
> patch on top of this series ?

Okay.

> > -     DRM_DEBUG("\n");
> > +     drm_dbg_core(NULL, "\n");
> 
> This is even worse :-) The next two messages are also fairly useless,
> they should be expanded, or dropped.

Okay.

> > -     DRM_DEBUG("\n");
> > +   drm_dbg_core(dev, "\n");
> 
> Ditto.

Okay.

> > +   drm_dbg_core(dev, "\n");
> > +
> 
> Same, and the two messages below too.

Okay.

> > -   DRM_DEBUG("\n");
> > +     drm_dbg_core(dev, "\n");
> 
> Here too.

Okay.

> With the commit subject fixed,
> 
> Reviewed-by: Laurent Pinchart laurent.pinchart+renesas@...asonboard.com>

Thanks,
Siddh