linux-kernel - Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afe1c05a-2b77-c3d8-aacf-b4c7bebb8bf8@intel.com>
Date:   Tue, 6 Jun 2023 08:00:33 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints

On 25/05/23 11:29, Adrian Hunter wrote:
> Hi
> 
> Here is a patch (V3) to the event parser for breakpoint events.
> I am not that familiar with flex / bison, but it seemed to
> need trailing context to stop the mem event colon and slash
> delimiters from getting mixed up with delimiters for config
> terms or event modifiers.  Please look closely at that.
> 
> 
> Changes in V3:
> 
>       Add Ian's Reviewed-by
>       Re-base

Still applies.  Any more comments?

> 
> Changes in V2:
> 
>       Add comments to tools/perf/util/parse-events.l
>       Add a test for 2 mem events back to back with config terms
> 
> 
> Adrian Hunter (1):
>       perf tools: Allow config terms with breakpoints
> 
>  tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/parse-events.c  |  23 +++++-
>  tools/perf/util/parse-events.h  |   6 +-
>  tools/perf/util/parse-events.l  |  23 +++++-
>  tools/perf/util/parse-events.y  |  42 ++++++-----
>  5 files changed, 224 insertions(+), 27 deletions(-)
> 
> 
> Regards
> Adrian