| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJ+vNU29qdtYTnby6XBJvnawbAKWc7O8uRVFBY7pPHOBRfNpxA@mail.gmail.com>
Date: Mon, 5 Jun 2023 17:00:18 -0700
From: Tim Harvey <tharvey@...eworks.com>
To: Shawn Guo <shawnguo@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp-venice-gw74xx: update to revB PCB
On Sun, Jun 4, 2023 at 5:22 PM Shawn Guo <shawnguo@...nel.org> wrote:
>
> On Thu, Jun 01, 2023 at 12:31:12PM -0700, Tim Harvey wrote:
> > Update the imx8mp-venice-gw74xx for revB:
> > - add CAN1
> > - add TIS-TPM on SPI2
> > - add FAN controller
> > - fix PMIC I2C bus (revA PMIC I2C was non-functional so no need for
> > backward compatible option)
> > - M2 socket GPIO's moved
> >
> > Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> > ---
> > .../dts/freescale/imx8mp-venice-gw74xx.dts | 261 +++++++++++-------
> > 1 file changed, 159 insertions(+), 102 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index eb51d648359b..0e389ec5c2d4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -125,12 +125,22 @@ reg_usb2_vbus: regulator-usb2 {
> > regulator-max-microvolt = <5000000>;
> > };
> >
> > + reg_can1_stby: regulator-can1-stby {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_can1>;
> > + regulator-name = "can1_stby";
> > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + };
> > +
> > reg_can2_stby: regulator-can2-stby {
> > compatible = "regulator-fixed";
> > pinctrl-names = "default";
> > - pinctrl-0 = <&pinctrl_reg_can>;
> > + pinctrl-0 = <&pinctrl_reg_can2>;
> > regulator-name = "can2_stby";
> > - gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> > + gpio = <&gpio5 5 GPIO_ACTIVE_LOW>;
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > };
> > @@ -164,6 +174,21 @@ &A53_3 {
> > cpu-supply = <®_arm>;
> > };
> >
> > +&ecspi1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_spi1>;
> > + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> > + status = "okay";
> > +
> > + tpm@0 {
> > + compatible = "tcg,tpm_tis-spi";
> > + #address-cells = <0x1>;
> > + #size-cells = <0x1>;
> > + reg = <0x0>;
> > + spi-max-frequency = <36000000>;
> > + };
> > +};
> > +
> > /* off-board header */
> > &ecspi2 {
> > pinctrl-names = "default";
> > @@ -204,6 +229,13 @@ fixed-link {
> > };
> > };
> >
> > +&flexcan1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_flexcan1>;
> > + xceiver-supply = <®_can1_stby>;
> > + status = "okay";
> > +};
> > +
> > &flexcan2 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_flexcan2>;
> > @@ -214,38 +246,38 @@ &flexcan2 {
> > &gpio1 {
> > gpio-line-names =
> > "", "", "", "", "", "", "", "",
> > - "", "", "dio0", "", "dio1", "", "", "",
> > + "", "dio0", "", "dio1", "", "", "", "",
> > "", "", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "";
> > };
> >
> > &gpio2 {
> > gpio-line-names =
> > - "", "", "", "", "", "", "", "",
> > - "", "", "", "", "", "", "pcie3_wdis#", "",
> > + "", "", "", "", "", "", "m2_pin20", "",
> > + "", "", "", "", "", "pcie1_wdis#", "pcie3_wdis#", "",
> > "", "", "pcie2_wdis#", "", "", "", "", "",
> > "", "", "", "", "", "", "", "";
> > };
> >
> > &gpio3 {
> > gpio-line-names =
> > - "m2_gdis#", "", "", "", "", "", "", "m2_rst#",
> > + "", "", "", "", "", "", "m2_rst", "",
> > + "", "", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "",
> > - "m2_off#", "", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "";
> > };
> >
> > &gpio4 {
> > gpio-line-names =
> > + "", "", "m2_off#", "", "", "", "", "",
> > "", "", "", "", "", "", "", "",
> > - "", "", "", "", "", "", "", "",
> > - "", "", "", "", "m2_wdis#", "", "", "",
> > - "", "", "", "", "", "", "", "uart_rs485";
> > + "", "", "m2_wdis#", "", "", "", "", "",
> > + "", "", "", "", "", "", "", "rs485_en";
> > };
> >
> > &gpio5 {
> > gpio-line-names =
> > - "uart_half", "uart_term", "", "", "", "", "", "",
> > + "rs485_hd", "rs485_term", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "",
> > "", "", "", "", "", "", "", "";
> > @@ -286,6 +318,12 @@ channel@8 {
> > label = "vdd_bat";
> > };
> >
> > + channel@16 {
> > + gw,mode = <4>;
> > + reg = <0x16>;
> > + label = "fan_tach";
> > + };
> > +
> > channel@82 {
> > gw,mode = <2>;
> > reg = <0x82>;
> > @@ -358,6 +396,11 @@ channel@a2 {
> > gw,voltage-divider-ohms = <10000 10000>;
> > };
> > };
> > +
> > + fan-controller@0 {
>
> The unit-address doesn't match 'reg' property below.
>
> Shawn
>
Shawn,
Thanks - I'll fix this in v2
Best Regards,
Tim
Powered by blists - more mailing lists