linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8192: Add missing dma-ranges to soc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 08:34:30 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     kernel@...labora.com, Yong Wu <yong.wu@...iatek.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8192: Add missing dma-ranges to
 soc node



On 05/06/2023 11:45, AngeloGioacchino Del Regno wrote:
> Il 01/06/23 22:32, Nícolas F. R. A. Prado ha scritto:
>> In the series "Adjust the dma-ranges for MTK IOMMU", the mtk-iommu
>> driver was adapted to separate the iova range based on the larb used,
>> and a dma-ranges property was added to the soc node in the devicetree of
>> the affected SoCs allowing the whole 16GB iova range to be used. Except
>> that for mt8192, there was no patch adding dma-ranges.
>>
>> Add the missing dma-ranges property to the soc node like was done for
>> mt8195 and mt8186. This fixes the usage of the vcodec, which would
>> otherwise trigger iommu faults.
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>>
>> ---
>> Matthias,
>>
>> this is a very simple but important fix for the vcodec functionality.
>> Since the vcodec node for mt8192 was just merged, can we please get this
>> in in this merge window as well?
> 
> +1
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 

Applied, thanks!

>>
>> Thanks,
>> Nícolas
>>
>>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>> index 7ff183c35494..a3612de8e9d1 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>> @@ -401,6 +401,7 @@ soc {
>>           #address-cells = <2>;
>>           #size-cells = <2>;
>>           compatible = "simple-bus";
>> +        dma-ranges = <0x0 0x0 0x0 0x0 0x4 0x0>;
>>           ranges;
>>           gic: interrupt-controller@...0000 {
>