linux-kernel - Re: make localmodconfig doesn't work for thunderbolt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 08:52:47 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        andreas.noever@...il.com, michael.jamet@...el.com,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        YehezkelShB@...il.com, USB list <linux-usb@...r.kernel.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: make localmodconfig doesn't work for thunderbolt

On 06. 06. 23, 6:16, Masahiro Yamada wrote:
> On Wed, May 10, 2023 at 8:01 PM Jiri Slaby <jirislaby@...nel.org> wrote:
>>
>> Hi,
>>
>> if I use localmodconfig for example like this:
>> mkdir /tmp/tb/
>> echo thunderbolt >/tmp/tb/lsmod
>> make O=/tmp/tb LSMOD=/tmp/tb/lsmod localmodconfig
>>
>> I get:
>> using config: '.config'
>> thunderbolt config not found!!
>>
>> $ grep 'USB4\>' /tmp/tb/.config
>> # CONFIG_USB4 is not set
>>
>> I believe it's due to:
>>     obj-${CONFIG_USB4} := thunderbolt.o
>> in drivers/thunderbolt/Makefile. I.e. ${} used instead of more common $().
>>
>> But even if I change the parser:
>>
>> --- a/scripts/kconfig/streamline_config.pl
>> +++ b/scripts/kconfig/streamline_config.pl
>> @@ -317,7 +317,7 @@ foreach my $makefile (@makefiles) {
>>           $_ = convert_vars($_, %make_vars);
>>
>>           # collect objects after obj-$(CONFIG_FOO_BAR)
>> -       if (/obj-\$\((CONFIG_[^\)]*)\)\s*[+:]?=\s*(.*)/) {
>> +       if (/obj-\$[({](CONFIG_[^})]*)[)}]\s*[+:]?=\s*(.*)/) {
>>               $var = $1;
>>               $objs = $2;
>>
> 
> 
> Will you send this fix as a patch?

Hi,

ah, yes, sorry, I forgot. Today or tomorrow.

thanks for pinging me,
-- 
js
suse labs