linux-kernel - Re: [PATCH v2 1/1] test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b77284cc-06e7-69c1-1eaa-b3980ba7db71@alu.unizg.hr>
Date:   Tue, 6 Jun 2023 12:17:39 +0200
From:   Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>,
        Takashi Iwai <tiwai@...e.de>,
        Kees Cook <keescook@...omium.org>,
        "Luis R. Rodriguez" <mcgrof@...lug.rutgers.edu>,
        Scott Branden <sbranden@...adcom.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2 1/1] test_firmware: return ENOMEM instead of ENOSPC on
 failed memory allocation

On 6/6/23 09:14, Dan Carpenter wrote:
> On Tue, Jun 06, 2023 at 09:08:10AM +0200, Mirsad Goran Todorovac wrote:
>> In a couple of situations like
>>
>> 	name = kstrndup(buf, count, GFP_KERNEL);
>> 	if (!name)
>> 		return -ENOSPC;
>>
>> the error is not actually "No space left on device", but "Out of memory".
>>
>> It is semantically correct to return -ENOMEM in all failed kstrndup()
>> and kzalloc() cases in this driver, as it is not a problem with disk
>> space, but with kernel memory allocator failing allocation.
>>
>> The semantically correct should be:
>>
>>          name = kstrndup(buf, count, GFP_KERNEL);
>>          if (!name)
>>                  return -ENOMEM;
>>
>> Cc: Dan Carpenter <error27@...il.com>
>> Cc: Takashi Iwai <tiwai@...e.de>
>> Cc: Kees Cook <keescook@...omium.org>
>> Cc: "Luis R. Rodriguez" <mcgrof@...lug.rutgers.edu>
>> Cc: Scott Branden <sbranden@...adcom.com>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>> Cc: Brian Norris <briannorris@...omium.org>
>> Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
>> Fixes: 0a8adf584759c ("test: add firmware_class loader test")
>> Fixes: 548193cba2a7d ("test_firmware: add support for firmware_request_platform")
>> Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger")
>> Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger")
>> Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
>> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
>> ---
> 
> Thanks!

Thank you for reviewing the patch at such a short notice.
Though it is merely a code consistency fix.

Best regards,
Mirsad Todorovac

> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> regards,
> dan carpenter

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia