linux-kernel - Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 12:31:59 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-next <linux-next@...r.kernel.org>,
        lkft-triage@...ts.linaro.org,
        clang-built-linux <llvm@...ts.linux.dev>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Netdev <netdev@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Anders Roxell <anders.roxell@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        maxime.chevallier@...tlin.com,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy

Hi Arnd,

On Tue, Jun 6, 2023 at 12:21 PM Arnd Bergmann <arnd@...db.de> wrote:
> On Tue, Jun 6, 2023, at 11:28, Geert Uytterhoeven wrote:
> > On Tue, Jun 6, 2023 at 11:16 AM Arnd Bergmann <arnd@...db.de> wrote:
> >> On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote:
> >>
> >> This won't work when PCS_LYNX is a loadable module and
> >> STMMAC is built-in. I think we should just select PCS_LYNX
> >
> > Oops, you're right, forgot about that case.
> > What about using IS_REACHABLE() instead?
> > No, that won't work either, as DWMAC_SOCFPGA can be modular,
> > with STMMAC builtin.
>
> It would work because of the 'select PCS_LYNX' below DWMAC_SOCFPGA,

That was my first thought, but it won't work, as DWMAC_SOCFPGA=m
causes PCS_LYNX=m, while main STMMAC can still be builtin.

> but I think that's too fragile and would easily break when another
> dwmac front-end starts using PCS_LYNX without have the same select
> statement. I think we should always avoid IS_REACHABLE().

;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds