linux-kernel - Re: [PATCH] crypto: md4: Fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2023 19:22:32 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     Franziska Naepelt <franziska.naepelt@...glemail.com>,
        linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
        davem@...emloft.net, linux-kernel@...r.kernel.org,
        Franziska Naepelt <franziska.naepelt@...il.com>,
        Linux SPDX Licenses <linux-spdx@...r.kernel.org>,
        James Morris <jmorris@...ercode.com.au>,
        Steve French <sfrench@...ba.org>
Subject: Re: [PATCH] crypto: md4: Fix checkpatch issues

On 6/6/23 19:18, Ard Biesheuvel wrote:
> On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@...il.com> wrote:
>>
>> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
>>> The following checkpatch issues have been fixed:
>>> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>>> - ERROR: space required after that ',' (ctx:VxV)
>>> - ERROR: space prohibited after that open square bracket '['
>>> - WARNING: space prohibited between function name and open parenthesis '('
>>> - ERROR: code indent should use tabs where possible
>>
>> Again, please split up into one patch per fixes, as a patch series.
>>
> 
> Apart from the SPDX conversion, I think it is fine to fix multiple
> different whitespace issues in the same file with one patch. Splitting
> that up is just busywork.
> 

Do you mean SPDX conversion in one patch and the rest in another? I think
so and confused...

-- 
An old man doll... just what I always wanted! - Clara