linux-kernel - Re: [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2023 18:07:22 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Yogesh Hegde <yogi.kernel@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode

On Wed, Jun 07, 2023 at 08:31:41PM +0530, Yogesh Hegde wrote:
> The variable SetWirelessMode is set in only one place throughout the
> driver. This patch removes the variable and calls the real function
> directly instead, eliminating the unnecessary indirection.
> Additionally, the removal of the variable aligns with the checkpatch
> guidelines by removing the use of CamelCase.
> 
> Signed-off-by: Yogesh Hegde <yogi.kernel@...il.com>
> ---
> 
> v2: Removed the variable and called the function direction instead of
>     just renaming the variable as suggested by Greg Kroah-Hartman
>     <gregkh@...uxfoundation.org>.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter