[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a6d96280-e222-1aaa-4e07-5fc4f0cde866@sberdevices.ru>
Date: Wed, 7 Jun 2023 18:21:50 +0300
From: Arseniy Krasnov <avkrasnov@...rdevices.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Miquel Raynal <miquel.raynal@...tlin.com>
CC: Liang Yang <liang.yang@...ogic.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
<oxffffaa@...il.com>, <kernel@...rdevices.ru>,
<linux-mtd@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-amlogic@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property
On 07.06.2023 18:07, Krzysztof Kozlowski wrote:
> On 07/06/2023 16:55, Arseniy Krasnov wrote:
>>>>> The bindings and your driver internal representation are two different
>>>>> things. Anyway, as mentioned above, wiring the RB line to one die and
>>>>> not the other would be valid hardware design and would require the rb
>>>>> property to be in the chip node. Please perform a per-chip property read
>>>>> in the driver as well.
>>>>
>>>> Done, I resend both patches (bindings + driver update) as a single patchset. Your review comments
>>>> for driver code were also fixed.
>>>
>>> No, please send new version, not the same. New version means with fixed
>>> comments and with patch changelog.
>>
>> Sorry, Yes, I mean new version, here it is:
>> https://lore.kernel.org/linux-mtd/20230607145026.2899547-1-AVKrasnov@sberdevices.ru/
>>
>> There I fixed bindings and tested it.
>
> I still see v1 and there is no changelog. So it's the same?
No, v1 is for new patchset from the link above. Both patches (bindings and driver) are updated there.
I attached changelog here as reply for cover letter of the patchset:
https://lore.kernel.org/linux-mtd/a1e048aa-ec64-bd0b-aa17-e3e9bdf18090@sberdevices.ru/
Thanks, Arseniy
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists