linux-kernel - Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CT6JSVJSSBN6.FDKEQEMESYD7@suppilovahvero>
Date:   Wed, 07 Jun 2023 19:11:04 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Ben Boeckel" <me@...boeckel.net>,
        "Dan Carpenter" <dan.carpenter@...aro.org>
Cc:     "Bagas Sanjaya" <bagasdotme@...il.com>,
        "Franziska Naepelt" <franziska.naepelt@...glemail.com>,
        <keyrings@...r.kernel.org>, <dhowells@...hat.com>,
        <dwmw2@...radead.org>, <linux-kernel@...r.kernel.org>,
        "Franziska Naepelt" <franziska.naepelt@...il.com>,
        "kernel test robot" <lkp@...el.com>,
        "Linux SPDX Licenses" <linux-spdx@...r.kernel.org>,
        "Linux Kernel Janitors" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues

On Wed Jun 7, 2023 at 12:43 AM EEST, Ben Boeckel wrote:
> On Tue, Jun 06, 2023 at 18:25:24 +0300, Dan Carpenter wrote:
> > I'm looking through the git log to see if it's true the imperative tense
> > commit message are shorter and better and neither one of those things is
> > obvious to me.
> > 
> > This patch had an imperative subject already so it was already kind of
> > imperative.  Does every sentence have to be imperative or can you just
> > add a "Fix it." to the end?
>
> I don't know about the length argument, but it feels like it reads
> better when skimming summaries with the imperative mood. The way I think
> about it is that the subject should complete the phrase:
>
>     When applied, this patch will…
>
> The body then gives more context and description as necessary. I don't
> really worry so much about the mood/tense/whatever in the body except
> that I try to use the present tense for anything the patch is doing and
> past for any historical context. I understand that kernel maintainers
> may care a lot more about it though.
>
> Basically, a patch, on its own, does nothing (just like a recipe). It is
> only when it is applied that anything actually happens. I read it as
> "`git apply`, please $summary".
>
> --Ben

+1

BR, Jarkko