linux-kernel - Re: [PATCH net-next] ethtool: ioctl: improve error checking for set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230606205437.49378d25@kernel.org>
Date:   Tue, 6 Jun 2023 20:54:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Justin Chen <justin.chen@...adcom.com>
Cc:     netdev@...r.kernel.org, simon.horman@...igine.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Daniil Tatianin <d-tatianin@...dex-team.ru>,
        Marco Bonelli <marco@...eim.net>,
        Gal Pressman <gal@...dia.com>, Jiri Pirko <jiri@...nulli.us>,
        Sean Anderson <sean.anderson@...o.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net-next] ethtool: ioctl: improve error checking for
 set_wol

On Mon,  5 Jun 2023 11:46:16 -0700 Justin Chen wrote:
> +	if (wol.wolopts & ~cur_wol.supported)
> +		return -EOPNOTSUPP;

One small comment - I think we should return -EINVAL here.
That's what netlink return and we seem to mostly return -EOPNOTSUPP
if the operation is completely not supported.
-- 
pw-bot: cr