linux-kernel - Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw73xx-2x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5ASwTJpH84SJX78k7MtZzwFc0bnbGqXsSFA6JFGq+0Emg@mail.gmail.com>
Date:   Wed, 7 Jun 2023 14:16:38 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Tim Harvey <tharvey@...eworks.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw73xx-2x

Hi Tim,

On Wed, Jun 7, 2023 at 2:12 PM Tim Harvey <tharvey@...eworks.com> wrote:

> +/* bluetooth HCI */
> +&uart3 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>;
> +       cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> +       rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> +       uart-has-rtscts;

'uart-has-rtscts' means: use native RTS and CTS lines, but you are
passing 'cts-gpios/rts-gpios',
which contradicts that.

I suggest you remove 'uart-has-rtscts'.