linux-kernel - Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2291292.1686158954@warthog.procyon.org.uk>
Date:   Wed, 07 Jun 2023 18:29:14 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Chuck Lever <chuck.lever@...cle.com>,
        Boris Pismenny <borisp@...dia.com>,
        John Fastabend <john.fastabend@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        David Ahern <dsahern@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Jens Axboe <axboe@...nel.dk>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES

Jakub Kicinski <kuba@...nel.org> wrote:

> > +		if (put)
> > +			put_page(page);
> 
> is put ever set to true?

Ah, the copy-data-if-slab thing got removed.  I'll clean this bit up.

> > -		tls_ctx->pending_open_record_frags = true;
> >  		copied += try_to_copy;
> > +copied:
> > +		tls_ctx->pending_open_record_frags = true;
> 
> Why move pending-open-record-frags setting if it's also set before
> jumping?

I should probably remove it from before the goto - unless you'd prefer to do
it in both places.

David