linux-kernel - Re: [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230607-camisole-unstaffed-d19110b9cc1c@spud>
Date:   Wed, 7 Jun 2023 21:46:03 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     jacopo.mondi@...asonboard.com, laurent.pinchart@...asonboard.com,
        martin.hecht@...et.eu, michael.roeder@...et.eu,
        linuxfancy@...glegroups.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Gerald Loacker <gerald.loacker@...fvision.net>,
        Mikhail Rudenko <mike.rudenko@...il.com>,
        Nicholas Roth <nicholas@...hemail.net>,
        Linus Walleij <linus.walleij@...aro.org>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Shawn Tu <shawnx.tu@...el.com>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML
 binding

On Wed, Jun 07, 2023 at 09:49:18PM +0200, Tommaso Merciai wrote:
> On Wed, Jun 07, 2023 at 06:16:19PM +0100, Conor Dooley wrote:
> > On Wed, Jun 07, 2023 at 03:19:24PM +0200, Tommaso Merciai wrote:

> You are suggesting the following solution:
> 
> minimum: 1
> maximum: 150000
> 
> Right?
> 
> Personally I prefer to keep also 0 but never mind
> is ok also this solution. :)
> 
> Let me know if I have understood correctly pls.
> Thanks in advance :)

Yup, you got it.

> > > +static int alvium_get_dt_data(struct alvium_dev *alvium)
> > > +{
> > > +	struct device *dev = &alvium->i2c_client->dev;
> > > +	struct device_node *node = dev->of_node;
> > > +	struct fwnode_handle *endpoint;
> > > +	int ret = 0;
> > > +
> > > +	if (!node)
> > > +		return -EINVAL;
> > > +
> > > +	ret = fwnode_property_read_u32(dev_fwnode(dev),
> > > +			  "alliedvision,lp2hs-delay-us",
> > > +			  &alvium->lp2hs_delay);
> > > +	if (ret)
> > > +		dev_info(dev, "lp2hs-delay-us not found\n");
> > 
> > And this print, which I also don't understand the presence of as
> > well behaving driver should be quiet, goes away.
> 
> Then you are suggesting to drop this print right?

Yeah, in general we do not want drivers to be printing things while they
are behaving correctly & not having the property isn't an error ;)

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)