linux-kernel - Re: [PATCH v3 3/5] arm64: libstub: Move KASLR handling functions to efi-stub-helper.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306071357.IBYToqAc-lkp@intel.com>
Date:   Wed, 7 Jun 2023 14:11:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexandre Ghiti <alexghiti@...osinc.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Ard Biesheuvel <ardb@...nel.org>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-efi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Alexandre Ghiti <alexghiti@...osinc.com>
Subject: Re: [PATCH v3 3/5] arm64: libstub: Move KASLR handling functions to
 efi-stub-helper.c

Hi Alexandre,

kernel test robot noticed the following build warnings:

[auto build test WARNING on efi/next]
[also build test WARNING on linus/master v6.4-rc5 next-20230606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexandre-Ghiti/riscv-Introduce-virtual-kernel-mapping-KASLR/20230606-203849
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
patch link:    https://lore.kernel.org/r/20230606123242.20804-4-alexghiti%40rivosinc.com
patch subject: [PATCH v3 3/5] arm64: libstub: Move KASLR handling functions to efi-stub-helper.c
config: i386-randconfig-i063-20230607 (https://download.01.org/0day-ci/archive/20230607/202306071357.IBYToqAc-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add efi https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
        git fetch efi next
        git checkout efi/next
        b4 shazam https://lore.kernel.org/r/20230606123242.20804-4-alexghiti@rivosinc.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/firmware/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306071357.IBYToqAc-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/firmware/efi/libstub/x86-stub.c:19:
>> drivers/firmware/efi/libstub/efistub.h:1145:59: warning: non-void function does not return a value [-Wreturn-type]
   static inline unsigned long efi_get_kimg_min_align(void) {}
                                                             ^
   1 warning generated.
--
   In file included from drivers/firmware/efi/libstub/efi-stub-helper.c:17:
>> drivers/firmware/efi/libstub/efistub.h:1145:59: warning: non-void function does not return a value [-Wreturn-type]
   static inline unsigned long efi_get_kimg_min_align(void) {}
                                                             ^
   drivers/firmware/efi/libstub/efi-stub-helper.c:867:2: warning: call to undeclared function 'caches_clean_inval_pou'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           caches_clean_inval_pou(*image_addr, *image_addr + kernel_codesize);
           ^
   2 warnings generated.


vim +1145 drivers/firmware/efi/libstub/efistub.h

  1143	
  1144	#ifndef efi_get_kimg_min_align
> 1145	static inline unsigned long efi_get_kimg_min_align(void) {}
  1146	#define efi_get_kimg_min_align efi_get_kimg_min_align
  1147	#endif
  1148	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki