linux-kernel - Re: [PATCH 2/2] sysctl: move security keys sysctl registration to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2003477.1686127009@warthog.procyon.org.uk>
Date:   Wed, 07 Jun 2023 09:36:49 +0100
From:   David Howells <dhowells@...hat.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     dhowells@...hat.com, keescook@...omium.org, yzaikin@...gle.com,
        jarkko@...nel.org, paul@...l-moore.com, jmorris@...ei.org,
        serge@...lyn.com, j.granados@...sung.com, brauner@...nel.org,
        ebiederm@...ssion.com, patches@...ts.linux.dev,
        linux-fsdevel@...r.kernel.org, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] sysctl: move security keys sysctl registration to its own file

Luis Chamberlain <mcgrof@...nel.org> wrote:

> The security keys sysctls are already declared on its own file,
> just move the sysctl registration to its own file to help avoid
> merge conflicts on sysctls.c, and help with clearing up sysctl.c
> further.
> 
> This creates a small penalty of 23 bytes:
> 
> ./scripts/bloat-o-meter vmlinux.1 vmlinux.2
> add/remove: 2/0 grow/shrink: 0/1 up/down: 49/-26 (23)
> Function                                     old     new   delta
> init_security_keys_sysctls                     -      33     +33
> __pfx_init_security_keys_sysctls               -      16     +16
> sysctl_init_bases                             85      59     -26
> Total: Before=21256937, After=21256960, chg +0.00%
> 
> But soon we'll be saving tons of bytes anyway, as we modify the
> sysctl registrations to use ARRAY_SIZE and so we get rid of all the
> empty array elements so let's just clean this up now.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>

Acked-by: David Howells <dhowells@...hat.com>