lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <835a3587-1e0f-64d7-1d1a-b639ae8b7307@sberdevices.ru>
Date:   Wed, 7 Jun 2023 11:57:09 +0300
From:   Arseniy Krasnov <avkrasnov@...rdevices.ru>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>
CC:     Liang Yang <liang.yang@...ogic.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        <oxffffaa@...il.com>, <kernel@...rdevices.ru>,
        <linux-mtd@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property



On 07.06.2023 11:53, Krzysztof Kozlowski wrote:
> On 07/06/2023 10:40, Arseniy Krasnov wrote:
>> Hello Miquel, 
>>
>> On 07.06.2023 10:58, Miquel Raynal wrote:
>>
>>> Hi Arseniy,
>>>
>>> AVKrasnov@...rdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:
>>>
>>>> Add description of 'nand-rb' property. Use "Fixes" because this property
>>>> must be supported since the beginning. For this controller 'nand-rb' is
>>>> stored in the controller node (not in chip), because it has only single
>>>> r/b wire for all chips.
>>>
>>> Sorry if I mislead you in the first place, but you could definitely
>>> have two chips and only one with RB wired. It needs to be defined in
>>> the chips.
>>
>> Ok, so to clarify: is it ok, that in bindings this property will be placed in the
>> chip, but in driver, i'm trying to read it from the controller node (thus  in
>> dts file it will be also in controller node)?
> 
> No, because how would your DTS pass validation? I understand you did not
> test the bindings, but this will improve, right?

Ok, i'll follow DTS layout in the driver, "test the bindings" You mean "make dt_binding_check"?

> 
>> Because in driver there is no sense
>> to store this value in chip structure. 
> 
> Driver does not shape the DTS. Hardware does.

Ok, Thanks

Thanks, Arseniy

> 
> 
> 
> Best regards,
> Krzysztof
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ