linux-kernel - Re: [PATCH v2 0/4] soundwire: qcom: stablity fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2023 10:36:40 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     vkoul@...nel.org, andersson@...nel.org,
        yung-chuan.liao@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] soundwire: qcom: stablity fixes



On 05/06/2023 10:08, Johan Hovold wrote:
> On Thu, May 25, 2023 at 02:38:08PM +0100, Srinivas Kandagatla wrote:
>> During x13s audio testing we hit few corner cases due to issues
>> in codec drivers and some obvious code bugs.
>>
>> Here are the fixes for those issues, mostly the issues are around
>> devices loosing the sync in between runtime pm suspend resume path.
>>
>> With codec fixes along with these fixes, audio on x13s is pretty stable.
>>
>> Thanks,
>> Srini
>>
>> Changes since v1:
>> 	- dropped runtime pm changes patch as unable to reproduced it anymore
>> 	- fixed clk stop flag as suggested by Pierre
>> 	- rebased on top of linux-next
> 
> I tried to update to this series on my 6.4-rc5 branch for the X13s and
> the above changes appear to lead to breakages again.
> 
These patches are based on linux next, we can not cleanly apply them on 
rc5 i guess without the depended patches.

I have tried these patches with your rc4 branch along with other 
depended patches my branch is at: 
https://git.linaro.org/people/srinivas.kandagatla/linux.git/log/?h=wip/sc8280xp-v6.4-rc4

this works fine for me, not seeing any issues so far.
tested both speakers and headset.


> Specifically, with the updated clk stop flag (simple_clk_stop_capable) I
> see:
> 
> [   14.789533] wcd9380-codec sdw:0:0217:010d:00:3: Slave 1 state check1: UNATTACHED, status was 1
> [   14.789717] qcom-soundwire 3330000.soundwire-controller: qcom_swrm_irq_handler: SWR bus clsh detected
> [   14.796164] wcd9380-codec sdw:0:0217:010d:00:3: Slave 1 state check1: UNATTACHED, status was 1
> 

> and without the runtime pm patch that you dropped in v2 I get
> intermittent (e.g. twice in five boots):
> 
> [   11.527301] snd-sc8280xp sound: ASoC: adding FE link failed
> [   11.527409] snd-sc8280xp sound: ASoC: topology: could not load header: -517
Never seen this, looks like some corrupted tplg to me.. I might be wrong.

> [   11.527557] qcom-apm gprsvc:service:2:1: tplg component load failed-517
> [   11.527640] qcom-apm gprsvc:service:2:1: ASoC: error at snd_soc_component_probe on gprsvc:service:2:1: -22
> [   11.528079] snd-sc8280xp sound: ASoC: failed to instantiate card -22
> [   11.533388] snd-sc8280xp: probe of sound failed with error -22
> 
> Again, this was with 6.4-rc5, but these problems are likely still there
> also with linux-next.

Have you tried linux-next?


--srini
> 
> Johan