linux-kernel - Re: [PATCH] gpio: tegra186: Check PMC driver status before any request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2023 11:55:24 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Prathamesh Shete <pshete@...dia.com>, linus.walleij@...aro.org,
        brgl@...ev.pl, thierry.reding@...il.com,
        linux-tegra@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     smangipudi@...dia.com, Manish Bhardwaj <mbhardwaj@...dia.com>
Subject: Re: [PATCH] gpio: tegra186: Check PMC driver status before any
 request


On 06/06/2023 09:53, Jon Hunter wrote:
> 
> On 06/06/2023 08:17, Prathamesh Shete wrote:
>> This patch fixes the issue where even if PMC driver status is
>> disabled still we are trying to look up for the IRQ domain
>> that PMC driver would've registered if it had been enabled.
> 
> It might be clearer to say ...
> 
> When the PMC device is disabled, probing of the Tegra186 GPIO driver 
> fails because the IRQ domain that is registered by the PMC driver is not 
> found. Fix this by checking to see if the PMC device is enabled before 
> attempting to lookup the IRQ domain registered by the PMC.

It could also be worth noting that it is OK to skip the PMC IRQ domain 
in this case because this only impacts wake-ups and not GPIO 
functionality in general.

Jon

-- 
nvpublic