linux-kernel - Re: [PATCH v2 2/2] mm/mm_init.c: remove reset_node_present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2023 13:38:54 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Haifeng Xu <haifeng.xu@...pee.com>
Cc:     rppt@...nel.org, osalvador@...e.de, mhocko@...nel.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mm/mm_init.c: remove reset_node_present_pages()

On 07.06.23 04:50, Haifeng Xu wrote:
> reset_node_present_pages() only get called in hotadd_init_pgdat(), move
> the action that clear present pages to free_area_init_core_hotplug(), so
> the helper can be removed.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@...pee.com>
> Suggested-by: David Hildenbrand <david@...hat.com>
> ---
> v2:
> - declare 'struct zone' within the for loop
> - fix comment layout
> ---
>   mm/memory_hotplug.c | 18 ------------------
>   mm/mm_init.c        | 15 +++++++++++++--
>   2 files changed, 13 insertions(+), 20 deletions(-)

As Michal said, we could be clearer that this simplifies the code (and 
removes a TODO).

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb