[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230607120857.3621364-1-arnd@kernel.org>
Date: Wed, 7 Jun 2023 14:08:54 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>,
Peter Zijlstra <peterz@...radead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Huacai Chen <chenhuacai@...nel.org>,
linux-kernel@...r.kernel.org
Subject: [PATCH] sysctl: fix unused proc_cap_handler() function warning
From: Arnd Bergmann <arnd@...db.de>
Since usermodehelper_table() is marked static now, we get a
warning about it being unused when SYSCTL is disabled:
kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]
Just move it inside of the same #ifdef.
Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
kernel/umh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/umh.c b/kernel/umh.c
index d5dc3cc92d5c6..2f9249c2bf6ce 100644
--- a/kernel/umh.c
+++ b/kernel/umh.c
@@ -494,6 +494,7 @@ int call_usermodehelper(const char *path, char **argv, char **envp, int wait)
}
EXPORT_SYMBOL(call_usermodehelper);
+#if defined(CONFIG_SYSCTL)
static int proc_cap_handler(struct ctl_table *table, int write,
void *buffer, size_t *lenp, loff_t *ppos)
{
@@ -544,7 +545,6 @@ static int proc_cap_handler(struct ctl_table *table, int write,
return 0;
}
-#if defined(CONFIG_SYSCTL)
static struct ctl_table usermodehelper_table[] = {
{
.procname = "bset",
--
2.39.2
Powered by blists - more mailing lists