linux-kernel - Re: [PATCH v2 2/6] dt-bindings: clock: Add YAML schemas for LPASS AUDIOCC and reset on SC8280XP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ff3ba78-2af3-5226-0289-6aff63f41060@linaro.org>
Date:   Wed, 7 Jun 2023 14:15:24 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     johan+linaro@...nel.org, agross@...nel.org,
        konrad.dybcio@...aro.org, mturquette@...libre.com,
        sboyd@...nel.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: clock: Add YAML schemas for LPASS
 AUDIOCC and reset on SC8280XP



On 31/05/2023 20:59, Krzysztof Kozlowski wrote:
> On 25/05/2023 14:29, Srinivas Kandagatla wrote:
>> The LPASS (Low Power Audio Subsystem) Audio clock controller provides reset
>> support when it is under the control of Q6DSP.
>>
> 
> A nit, subject: drop second/last, redundant "YAML schemas for". The
> "dt-bindings" prefix is already stating that these are
> bindings/schemas/YAML/etc.
> 
> Same comment for first patch.
> 
Thanks, will fix in v3

--srini
> 
>> Add support for those resets and adds IDs for clients to request the reset.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>>   .../bindings/clock/qcom,sc8280xp-lpasscc.yaml         | 11 +++++++++++
>>   include/dt-bindings/clock/qcom,lpasscc-sc8280xp.h     |  5 +++++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
>> index 08a9ae60a365..0557e74d3c3b 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
>> @@ -21,6 +21,7 @@ properties:
>>   
>>     compatible:
>>       enum:
>> +      - qcom,sc8280xp-lpassaudiocc
>>         - qcom,sc8280xp-lpasscc
>>   
>>     qcom,adsp-pil-mode:
>> @@ -45,6 +46,16 @@ required:
>>   additionalProperties: false
>>   
>>   examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,lpasscc-sc8280xp.h>
>> +    lpass_audiocc: clock-controller@...9000 {
>> +        compatible = "qcom,sc8280xp-lpassaudiocc";
>> +        reg = <0x032a9000 0x1000>;
>> +        qcom,adsp-pil-mode;
>> +        #reset-cells = <1>;
>> +        #clock-cells = <1>;
>> +    };
> 
> No need for new example - it's basically the same.
> 
> Best regards,
> Krzysztof
>