linux-kernel - Re: [PATCH v2] phy: tegra: xusb: Fix use-after-free issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <377c2bd5aa9d2363c2a9a0e63849207c12f47289.camel@nvidia.com>
Date:   Wed, 7 Jun 2023 02:34:15 +0000
From:   Haotien Hsu <haotienh@...dia.com>
To:     "thierry.reding@...il.com" <thierry.reding@...il.com>
CC:     "kishon@...nel.org" <kishon@...nel.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        EJ Hsu <ejh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Wayne Chang <waynec@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        Jui Chang Kuo <jckuo@...dia.com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>
Subject: Re: [PATCH v2] phy: tegra: xusb: Fix use-after-free issue

On Tue, 2023-06-06 at 14:35 +0200, Thierry Reding wrote:
> On Mon, May 08, 2023 at 06:03:20PM +0800, Haotien Hsu wrote:
> > From: EJ Hsu <ejh@...dia.com>
> > 
> > For the dual-role port, it will assign the phy dev to usb-phy dev
> > and
> > use the port dev driver as the dev driver of usb-phy.
> > 
> > When we try to destroy the port dev, it will destroy its dev driver
> > as well. But we did not remove the reference from usb-phy dev. This
> > might cause the use-after-free issue in KASAN.
> > 
> > Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
> > Cc: stable@...r.kernel.org
> > 
> > Signed-off-by: EJ Hsu <ejh@...dia.com>
> > Signed-off-by: Haotien Hsu <haotienh@...dia.com>
> > ---
> > V1 -> V2: Remove extra movements to clarify the change
> > ---
> >  drivers/phy/tegra/xusb.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Haotien,
> 
> I had already given an Acked-by on v1. Typically you should add such
> tags when you post new versions so that people don't have to repeat
> them. Anyway, here it is again:
> 
> Acked-by: Thierry Reding <treding@...dia.com>

Hi Thierry,

I see.
My mistake.