linux-kernel - Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZICKmA1kcDa2nG53@kernel.org>
Date:   Wed, 7 Jun 2023 10:48:08 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints

Em Wed, Jun 07, 2023 at 08:33:07AM +0300, Adrian Hunter escreveu:
> Maybe this is cleaner:

It is, I folded it into your original patch, thanks!

- Arnaldo
 
> 
> From: Adrian Hunter <adrian.hunter@...el.com>
> Date: Wed, 7 Jun 2023 08:12:29 +0300
> Subject: [PATCH] perf tools: Suppress bison unused value warnings
> 
> Patch "perf tools: Allow config terms with breakpoints" introduced
> parse tokens for colons and slashes within breakpoint parsing to
> prevent mix up with colons and slashes related to config terms.
> 
> The token values are not needed but introduce bison "unused value"
> warnings.
> 
> Suppress those warnings.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/util/parse-events.h | 4 ++++
>  tools/perf/util/parse-events.y | 7 +++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
> index b0eb95f93e9c..5fdc1f33f57e 100644
> --- a/tools/perf/util/parse-events.h
> +++ b/tools/perf/util/parse-events.h
> @@ -228,6 +228,10 @@ void parse_events_error__handle(struct parse_events_error *err, int idx,
>  void parse_events_error__print(struct parse_events_error *err,
>  			       const char *event);
>  
> +static inline void parse_events_unused_value(const void *x __maybe_unused)
> +{
> +}
> +
>  #ifdef HAVE_LIBELF_SUPPORT
>  /*
>   * If the probe point starts with '%',
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index bbfb8110947c..0c3d086cc22a 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -510,6 +510,9 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event
>  	struct list_head *list;
>  	int err;
>  
> +	parse_events_unused_value(&$3);
> +	parse_events_unused_value(&$5);
> +
>  	list = alloc_list();
>  	ABORT_ON(!list);
>  	err = parse_events_add_breakpoint(_parse_state, list,
> @@ -528,6 +531,8 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE opt_event_config
>  	struct list_head *list;
>  	int err;
>  
> +	parse_events_unused_value(&$3);
> +
>  	list = alloc_list();
>  	ABORT_ON(!list);
>  	err = parse_events_add_breakpoint(_parse_state, list,
> @@ -545,6 +550,8 @@ PE_PREFIX_MEM PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config
>  	struct list_head *list;
>  	int err;
>  
> +	parse_events_unused_value(&$3);
> +
>  	list = alloc_list();
>  	ABORT_ON(!list);
>  	err = parse_events_add_breakpoint(_parse_state, list,
> -- 
> 2.34.1
> 
> 

-- 

- Arnaldo