linux-kernel - Re: [PATCH] spi: fsl-dspi: avoid SCK glitches with continuous transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa5896d1-6034-404b-9645-9f976283b505@sirena.org.uk>
Date:   Wed, 7 Jun 2023 15:02:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     linux-spi@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>,
        linux-kernel@...r.kernel.org, Lisa Chen <minjie.chen@...kplus.com>
Subject: Re: [PATCH] spi: fsl-dspi: avoid SCK glitches with continuous
 transfers

On Wed, Jun 07, 2023 at 03:03:44PM +0300, Vladimir Oltean wrote:
> On Tue, May 30, 2023 at 01:34:02AM +0300, Vladimir Oltean wrote:

> I know you don't appreciate content-free pings, but is this patch on
> your radar?

It's only been a week, please allow a reasonable time for review
especially when there may be other people who work on the driver and
should be given a chance to review as is the case here.  Had I not
already put this into my CI I'd most likely give it a bit longer...

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)