linux-kernel - Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230608163812.GC3572061@google.com>
Date:   Thu, 8 Jun 2023 17:38:12 +0100
From:   Lee Jones <lee@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     pavel@....cz, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which
 can never be negative

On Wed, 31 May 2023, Yang Li wrote:

> The return value from the call to cht_wc_leds_find_freq() is int.
> However, the return value is being assigned to an unsigned
> int variable 'ctrl', so making it an int.
> 
> Eliminate the following warning:
> drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/leds/leds-cht-wcove.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]