linux-kernel - Re: [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into multiple drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230608172749.GJ3572061@google.com>
Date:   Thu, 8 Jun 2023 18:27:49 +0100
From:   Lee Jones <lee@...nel.org>
To:     Henning Schild <henning.schild@...mens.com>
Cc:     Pavel Machek <pavel@....cz>, Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into
 multiple drivers

On Wed, 24 May 2023, Henning Schild wrote:

> In order to clearly describe the dependencies between the GPIO
> controller drivers and the users the driver is split up into a core,
> two drivers and a common header.
> 
> Signed-off-by: Henning Schild <henning.schild@...mens.com>
> ---
>  drivers/leds/simple/Makefile                  |   4 +-
>  .../simple/simatic-ipc-leds-gpio-apollolake.c |  66 +++++++
>  .../leds/simple/simatic-ipc-leds-gpio-core.c  | 104 +++++++++++
>  .../simple/simatic-ipc-leds-gpio-f7188x.c     |  66 +++++++
>  drivers/leds/simple/simatic-ipc-leds-gpio.c   | 163 ------------------
>  drivers/leds/simple/simatic-ipc-leds-gpio.h   |  22 +++
>  drivers/leds/simple/simatic-ipc-leds.c        |   1 -
>  drivers/platform/x86/simatic-ipc.c            |   7 +-
>  8 files changed, 265 insertions(+), 168 deletions(-)
>  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c
>  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c
>  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c
>  delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c
>  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h

Applied, thanks

-- 
Lee Jones [李琼斯]