linux-kernel - Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <429589f6-d946-9bc9-d54e-e892d513a91b@amlogic.com>
Date:   Thu, 8 Jun 2023 11:23:46 +0800
From:   Liang Yang <liang.yang@...ogic.com>
To:     Arseniy Krasnov <avkrasnov@...rdevices.ru>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     oxffffaa@...il.com, kernel@...rdevices.ru,
        linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with
 zeroes



On 2023/6/8 5:18, Arseniy Krasnov wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi again Miquel, Liang!
> 
> What do You think about this patch?
> 
> Thanks, Arseniy
> 
> On 05.06.2023 22:15, Arseniy Krasnov wrote:
>> Both operations have no effect.
>>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@...rdevices.ru>
>> ---
>>   drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>> index 074e14225c06..50d3110ad321 100644
>> --- a/drivers/mtd/nand/raw/meson_nand.c
>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>>        cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>>        nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>>
>> -     addrs[0] = cs | NFC_CMD_ALE | 0;
>> +     addrs[0] = cs | NFC_CMD_ALE;
>>        if (mtd->writesize <= 512) {
>>                cmd_num--;
>>                row_start = 1;
>>        } else {
>> -             addrs[1] = cs | NFC_CMD_ALE | 0;
>> +             addrs[1] = cs | NFC_CMD_ALE;
>>                row_start = 2;
>>        }
Hi Arseniy and Miquel,

The two zeros indcates two column address. maybe we could use the micro 
"COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | 
ALE | addr" consistency and also let function 
"meson_nfc_rw_cmd_prepare_and_execute" be more readable.

Thanks,
Liang

>>