linux-kernel - Re: [PATCH v2 5.4 0/2] Backport few dfs related fixes to cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a664029640828958e152e9a4c11c4b9a.pc@manguebit.com>
Date:   Thu, 08 Jun 2023 17:54:26 -0300
From:   Paulo Alcantara <pc@...guebit.com>
To:     Rishabh Bhatnagar <risbhat@...zon.com>, gregkh@...uxfoundation.org
Cc:     sfrench@...zon.com, stable@...r.kernel.org,
        linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rishabh Bhatnagar <risbhat@...zon.com>
Subject: Re: [PATCH v2 5.4 0/2] Backport few dfs related fixes to cifs

Rishabh Bhatnagar <risbhat@...zon.com> writes:

> Recently we have been seeing kernel panic in cifs_reconnect function
> while accessing tgt_list. Looks like tgt_list is not initialized
> correctly. There are fixes already present in 5.10 and later trees.
> Backporting them to 5.4
>
>  CIFS VFS: \\172.30.1.14 cifs_reconnect: no target servers for DFS
>  failover
>  BUG: unable to handle page fault for address: fffffffffffffff8
>  #PF: supervisor read access in kernel mode
>  #PF: error_code(0x0000) - not-present page
>  PGD 260e067 P4D 260e067 PUD 2610067 PMD 0
>  Oops: 0000 [#1] SMP PTI
>  RIP: 0010:cifs_reconnect+0x51d/0xef0 [cifs]
>  RSP: 0018:ffffc90000693da0 EFLAGS: 00010282
>  RAX: fffffffffffffff8 RBX: ffff8887fa63b800 RCX: fffffffffffffff8
>  Call Trace:
>  cifs_handle_standard+0x18d/0x1b0 [cifs]
>  cifs_demultiplex_thread+0xa5c/0xc90 [cifs]
>  kthread+0x113/0x130
>
> Paulo Alcantara (2):
>   cifs: get rid of unused parameter in reconn_setup_dfs_targets()
>   cifs: handle empty list of targets in cifs_reconnect()
>
>  fs/cifs/connect.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Looks good.