linux-kernel - Re: [PATCH v5 3/3] media: i2c: Add support for alvium camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306090401.jEkSrYuJ-lkp@intel.com>
Date:   Fri, 9 Jun 2023 05:08:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, jacopo.mondi@...asonboard.com,
        laurent.pinchart@...asonboard.com, martin.hecht@...et.eu,
        michael.roeder@...et.eu, linuxfancy@...glegroups.com,
        Tommaso Merciai <tomm.merciai@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Gerald Loacker <gerald.loacker@...fvision.net>,
        Nicholas Roth <nicholas@...hemail.net>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Linus Walleij <linus.walleij@...aro.org>,
        Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
        Mikhail Rudenko <mike.rudenko@...il.com>,
        Shawn Tu <shawnx.tu@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/3] media: i2c: Add support for alvium camera

Hi Tommaso,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v6.4-rc5 next-20230608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tommaso-Merciai/dt-bindings-vendor-prefixes-Add-prefix-alliedvision/20230608-163423
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230608083127.545750-4-tomm.merciai%40gmail.com
patch subject: [PATCH v5 3/3] media: i2c: Add support for alvium camera
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230609/202306090401.jEkSrYuJ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add media-tree git://linuxtv.org/media_tree.git
        git fetch media-tree master
        git checkout media-tree/master
        b4 shazam https://lore.kernel.org/r/20230608083127.545750-4-tomm.merciai@gmail.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/media/i2c/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306090401.jEkSrYuJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/alvium-csi2.c: In function 'alvium_get_dt_data':
>> drivers/media/i2c/alvium-csi2.c:3245:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
    3245 |         int ret = 0;
         |             ^~~


vim +/ret +3245 drivers/media/i2c/alvium-csi2.c

  3239	
  3240	static int alvium_get_dt_data(struct alvium_dev *alvium)
  3241	{
  3242		struct device *dev = &alvium->i2c_client->dev;
  3243		struct device_node *node = dev->of_node;
  3244		struct fwnode_handle *endpoint;
> 3245		int ret = 0;
  3246	
  3247		if (!node)
  3248			return -EINVAL;
  3249	
  3250		ret = fwnode_property_read_u32(dev_fwnode(dev),
  3251				  "alliedvision,lp2hs-delay-us",
  3252				  &alvium->lp2hs_delay);
  3253	
  3254		endpoint = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL);
  3255		if (!endpoint) {
  3256			dev_err(dev, "endpoint node not found\n");
  3257			return -EINVAL;
  3258		}
  3259	
  3260		if (v4l2_fwnode_endpoint_alloc_parse(endpoint, &alvium->ep)) {
  3261			dev_err(dev, "could not parse endpoint\n");
  3262			return 0;
  3263		}
  3264	
  3265		if (alvium->ep.bus_type != V4L2_MBUS_CSI2_DPHY) {
  3266			dev_err(dev, "unsupported bus type\n");
  3267			return -EINVAL;
  3268		}
  3269	
  3270		if (!alvium->ep.nr_of_link_frequencies) {
  3271			dev_err(dev, "no link frequencies defined");
  3272			return -EINVAL;
  3273		}
  3274	
  3275		dev_info(dev, "freq: %llu\n",
  3276					    alvium->ep.link_frequencies[0]);
  3277		dev_info(dev, "lanes: %d\n",
  3278					    alvium->ep.bus.mipi_csi2.num_data_lanes);
  3279	
  3280		return 0;
  3281	}
  3282	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki