[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <797c61d2-b8f1-e80e-24b9-4c7a7d266080@linaro.org>
Date: Thu, 8 Jun 2023 08:37:57 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Billy Tsai <billy_tsai@...eedtech.com>, jdelvare@...e.com,
linux@...ck-us.net, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, joel@....id.au, andrew@...id.au,
thierry.reding@...il.com, u.kleine-koenig@...gutronix.de,
corbet@....net, p.zabel@...gutronix.de,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-pwm@...r.kernel.org, linux-doc@...r.kernel.org,
patrick@...cx.xyz
Subject: Re: [v6 0/4] Support pwm/tach driver for aspeed ast26xx
On 08/06/2023 04:18, Billy Tsai wrote:
> Unlike the old design that the register setting of the TACH should based
> on the configure of the PWM. In ast26xx, the dependency between pwm and
> tach controller is eliminated and becomes a separate hardware block. One
> is used to provide pwm output and another is used to monitor the frequency
> of the input. Therefore, this patch serials implements them by writing the
> two driver "pwm-aspeed-ast2600.c" and "tach-aspeed-ast2600.c". The former
> is following the pwm subsystem which can apply the existed driver to
> controller the fan(pwm-fan.c), beeper(pwm-beeper.c) and so on. The latter
> is following the sysfs interface of hwmon to creat the node for fan
> monitor.
You like to ignore my comments... How did you implement them? Go one by
one - answer to v4 emails.
Best regards,
Krzysztof
Powered by blists - more mailing lists