linux-kernel - Re: [PATCH] scripts/gdb: Fix SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2023 09:31:02 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Florian Fainelli <florian.fainelli@...adcom.com>
Cc:     linux-kernel@...r.kernel.org, gehao@...inos.cn,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Pankaj Raghav <p.raghav@...sung.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] scripts/gdb: Fix SB_* constants parsing

On Wed, Jun 07, 2023 at 03:13:35PM -0700, Florian Fainelli wrote:
> After f15afbd34d8f ("fs: fix undefined behavior in bit shift for
> SB_NOUSER") the constants were changed from plain integers which
> LX_VALUE() can parse to constants using the BIT() macro which causes the
> following:
> 
> Reading symbols from build/linux-custom/vmlinux...done.
> Traceback (most recent call last):
>   File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/vmlinux-gdb.py", line 25, in <module>
>     import linux.constants
>   File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/scripts/gdb/linux/constants.py", line 5
>     LX_SB_RDONLY = ((((1UL))) << (0))
> 
> Use LX_GDBPARSED() which does not suffer from that issue.
> 
> f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> ---

Fine by me,
Acked-by: Christian Brauner <brauner@...nel.org>