linux-kernel - RE: [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f13680401e449a3b9384710206cc2b0@realtek.com>
Date:   Thu, 8 Jun 2023 07:32:01 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Ray Chi <raychi@...gle.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Matthias Kaehlcke <mka@...omium.org>,
        "Flavio Suligoi" <f.suligoi@...m.it>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

Hi Krzysztof,

> 
> 1 phy or 4? Decide.

In actually, we have one phy for one controller.
I mean the driver can support up to 4 phys.
I can revised as
"^phy@[0]+$"
Or only "phy"

> > +
> > +patternProperties:
> > +  "^phy@[0-3]+$":
> > +    description: Each sub-node is a PHY device for one XHCI controller.
> > +    type: object
> > +    properties:
> > +      realtek,param:
> > +        description: The data of PHY parameter are the pair of the
> > +          offset and value.
> > +        $ref: /schemas/types.yaml#/definitions/uint8-array
> 
> Your choice of types is surprising. If this is array, than maxItems (and please
> don't tell me it is maxItems: 1). Anyway, why 8 bits long?

It should be a uint32-matrix.

> > +
> > +      realtek,do-toggle:
> > +        description: Set this flag to enable the PHY parameter toggle
> > +          when port status change.
> > +        type: boolean
> > +
> > +      realtek,do-toggle-once:
> > +        description: Set this flag to do PHY parameter toggle only on
> > +          PHY init.
> > +        type: boolean
> > +
> > +      realtek,check-efuse:
> > +        description: Enable to update PHY parameter from reading otp
> table.
> > +        type: boolean
> > +
> > +      realtek,use-default-parameter:
> > +        description: Don't set parameter and use default value in
> hardware.
> > +        type: boolean
> > +
> > +      realtek,check-rx-front-end-offset:
> > +        description: Enable to check rx front end offset.
> > +        type: boolean
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#address-cells"
> > +  - "#size-cells"
> > +  - "#phy-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    usb_port2_usb3phy: usb-phy@...10 {
> > +        compatible = "realtek,rtd1319d-usb3phy", "realtek,usb3phy";
> > +        reg = <0x13e10 0x4>;
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        #phy-cells = <0>;
> > +
> > +        phy@0 {
> > +            reg = <0>;
> > +            realtek,param =
> > +                    <0x01 0xac8c>,
> > +                    <0x06 0x0017>,
> 
> First, this is matrix, not uint8 array. Second, 0xac8c is past 16 bits long, not 8.
> Third, you put some magic register programming to DT.
> Please don't. Drop all this from DT.

realtek,param is an uint32-matrx.
I will revised the type.

Thanks,
Stanley