linux-kernel - Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIGcyku+DN5IHtwp@dhcp22.suse.cz>
Date:   Thu, 8 Jun 2023 11:18:02 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Haifeng Xu <haifeng.xu@...pee.com>
Cc:     David Hildenbrand <david@...hat.com>, rppt@...nel.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone

On Thu 08-06-23 15:38:48, Haifeng Xu wrote:
> 
> 
> On 2023/6/7 18:22, David Hildenbrand wrote:
> > On 07.06.23 12:16, Michal Hocko wrote:
> >> On Wed 07-06-23 09:07:34, Haifeng Xu wrote:
> >>> If freesize is less than dma_reserve, print warning message to report
> >>> this case.
> >>
> >> Why?
> > 
> > I'd like to second that question, and add
> > 
> > a) Did you run into that scenario?
> > b) What can an admin do in that case with that error messages?
> 
> In theory，dma_reserve shouldn't exceed freesize, so the error messages can remind us
> to verify whether the configuration of reserved memory is correct.

I am not really convinced this is worth touching the code TBH.

-- 
Michal Hocko
SUSE Labs