linux-kernel - Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIGf6mKwX9RIm5a5@ashyti-mobl2.lan>
Date:   Thu, 8 Jun 2023 11:31:22 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>
Cc:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

Hi Jingfeng,

On Thu, Jun 08, 2023 at 03:24:54PM +0800, Sui Jingfeng wrote:
> Hi,
> 
> thanks a lot
> 
> On 2023/6/8 15:15, Paul Kocialkowski wrote:
> > Hi,
> > 
> > On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
> > > drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
> > > two kconfig option, otherwise the driver failed to compile on platform
> > > without REGMAP_MMIO selected:
> > > 
> > > ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > > make: *** [Makefile:1978: modpost] Error 2
> > > 
> > > Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> > Thanks for the fix, looks good to me!
> > 
> > Acked-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> 
> After received this Acked-by, do a need append this tag to the patch, and
> resend this again?
> 
> I don't know about this.
> 
> I don't need to do anythings ales, you will push it to your repository,
> right?

no need... someone will pick it up and add the needed tags.

Andi