linux-kernel - Re: [PATCH] f2fs: enable nowait async buffered writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <059b17ce-cb65-fd55-29b1-2b253c6b41c4@kernel.org>
Date:   Thu, 8 Jun 2023 17:38:07 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yangtao Li <frank.li@...o.com>, Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     Lu Hongfei <luhongfei@...o.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: enable nowait async buffered writes

On 2023/6/6 19:13, Yangtao Li wrote:
> On 2023/6/6 14:43, Chao Yu wrote:
> 
>> On 2023/5/31 22:40, Yangtao Li wrote:
>>> This adds the async buffered write support to f2fs,
>>> the following is the relevant test data.
>>
>> Yangtao,
>>
>> Could you please provide detailed test command?
> 
> 
> Use fio to test, the following is the configuration:
> 
> # io_uring
> [global]
> ioengine=io_uring
> sqthread_poll=1
> threads=1
> iodepth=32
> hipri=0
> direct=0
> fixedbufs=0
> uncached=0
> nowait=0
> force_async=0
> randrepeat=0
> time_based=0
> size=256M
> filename=/data/test/local/io_uring_test
> group_reporting
> [read256B-rand]
> bs=4096
> rw=randwrite
> numjobs=1

Thanks, it looks the performance is not very stable when iodepth is
large, e.g. 32.

Could you please add above test parameter into commit message?

Otherwise, this patch looks good to me.

Thanks,

> 
> 
>>
>> Thanks,
>>
>>>
>>> iodepth      | 1    | 2    | 4    | 8    | 16   |
>>> before(M/s)  | 1012 | 1133 | 894  | 981  | 866  |
>>> after(M/s)   | 1488 | 1896 | 2081 | 2188 | 2207 |
>>>
>>> Signed-off-by: Lu Hongfei <luhongfei@...o.com>
>>> Signed-off-by: Yangtao Li <frank.li@...o.com>
>>> ---
>>>   fs/f2fs/file.c | 5 +----
>>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>>> index 23c68ee946e5..4faf2c04e325 100644
>>> --- a/fs/f2fs/file.c
>>> +++ b/fs/f2fs/file.c
>>> @@ -546,7 +546,7 @@ static int f2fs_file_open(struct inode *inode, struct file *filp)
>>>       if (err)
>>>           return err;
>>>   -    filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;
>>> +    filp->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC;
>>>         return dquot_file_open(inode, filp);
>>>   }
>>> @@ -4515,9 +4515,6 @@ static ssize_t f2fs_buffered_write_iter(struct kiocb *iocb,
>>>       struct inode *inode = file_inode(file);
>>>       ssize_t ret;
>>>   -    if (iocb->ki_flags & IOCB_NOWAIT)
>>> -        return -EOPNOTSUPP;
>>> -
>>>       current->backing_dev_info = inode_to_bdi(inode);
>>>       ret = generic_perform_write(iocb, from);
>>>       current->backing_dev_info = NULL;