linux-kernel - Re: [PATCH] tools: ynl: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZIG/hX09UKccKFO7@kernel.org>
Date:   Thu, 8 Jun 2023 13:46:13 +0200
From:   Simon Horman <horms@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] tools: ynl: Remove duplicate include

On Thu, Jun 08, 2023 at 05:30:36PM +0800, Jiapeng Chong wrote:
> ./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  tools/net/ynl/generated/netdev-user.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
> index aea5c7cc8ead..1883a658180b 100644
> --- a/tools/net/ynl/generated/netdev-user.c
> +++ b/tools/net/ynl/generated/netdev-user.c
> @@ -8,7 +8,6 @@
>  #include "ynl.h"
>  #include <linux/netdev.h>
>  
> -#include <stdlib.h>
>  #include <stdio.h>
>  #include <string.h>
>  #include <libmnl/libmnl.h>

This duplicates:

- [PATCH -next] tools: ynl: Remove duplicated include in handshake-user.c
  https://lore.kernel.org/all/20230608083148.5514-1-yang.lee@linux.alibaba.com/

So lets focus on that one.

In all three very similar patches were sent in a short space of time.
It's better not to do that.

-- 
pw-bot: reject