[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9c94397d-1e31-02fa-bdbe-af888c72eac4@loongson.cn>
Date: Thu, 8 Jun 2023 20:10:38 +0800
From: zhuyinbo <zhuyinbo@...ngson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
Liu Peibao <liupeibao@...ngson.cn>,
loongson-kernel@...ts.loongnix.cn, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings
在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
> On 08/06/2023 13:42, zhuyinbo wrote:
>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>> @@ -16,6 +16,7 @@ properties:
>> compatible:
>> enum:
>> - loongson,ls2k1000-spi
>> + - loongson,ls2k0500-spi
>
> Aren't they compatible?
>
Are you saying that the spi driver is compatible with 2k0500 ?
Yes. and the 2k1000 spi hardware was same with 2k0500 common type spi
hardware.
but afterwards, it may be necessary to implement a clock drvier for
2k0500, because the spi driver was use "devm_clk_get_optional()" to
get clock and not use "of_property_read_u32(np, "clock-frequency",
&clk)", But this seems to have nothing to do with bindings.
Thanks,
Yinbo
Powered by blists - more mailing lists