linux-kernel - Re: [PATCH 1/9] x86/hyperv: Add sev-snp enlightened guest static key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3d994c1-852e-dee7-e1ed-7b9ef307cb4f@gmail.com>
Date:   Thu, 8 Jun 2023 21:17:24 +0800
From:   Tianyu Lan <ltykernel@...il.com>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "arnd@...db.de" <arnd@...db.de>
Cc:     Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: Re: [PATCH 1/9] x86/hyperv: Add sev-snp enlightened guest static key

On 6/8/2023 8:56 PM, Michael Kelley (LINUX) wrote:
>> @ -473,7 +477,7 @@ static void __init ms_hyperv_init_platform(void)
>>
>>   #if IS_ENABLED(CONFIG_HYPERV)
>>   	if ((hv_get_isolation_type() == HV_ISOLATION_TYPE_VBS) ||
>> -	    (hv_get_isolation_type() == HV_ISOLATION_TYPE_SNP))
>> +	    ms_hyperv.paravisor_present)
> This test needs to be:
> 
>    	if ((hv_get_isolation_type() == HV_ISOLATION_TYPE_VBS) ||
> 	    ((hv_get_isolation_type() == HV_ISOLATION_TYPE_SNP) &&
> 	    ms_hyperv.paravisor_present)
> 
> We want to call hv_vtom_init() only when running with VBS, or
> with SEV-SNP*and*  we have a paravisor present.  Testing only for
> paravisor_present risks confusion with future TDX scenarios.

Yes, current paravisor is only available for VBS and SEV-SNP vTOM cases.
TDX may also have paravisor support. Will update.

Thanks.