[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BYAPR21MB16882DC67EAF87B518D5D72ED750A@BYAPR21MB1688.namprd21.prod.outlook.com>
Date: Thu, 8 Jun 2023 14:09:48 +0000
From: "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To: Tianyu Lan <ltykernel@...il.com>,
KY Srinivasan <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
"wei.liu@...nel.org" <wei.liu@...nel.org>,
Dexuan Cui <decui@...rosoft.com>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"bp@...en8.de" <bp@...en8.de>,
"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
"x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"arnd@...db.de" <arnd@...db.de>
CC: Tianyu Lan <Tianyu.Lan@...rosoft.com>,
"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: RE: [PATCH 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP
enlightened guest
From: Tianyu Lan <ltykernel@...il.com> Sent: Thursday, June 1, 2023 8:16 AM
>
[snip]
>
> +static __init void hv_snp_get_smp_config(unsigned int early)
> +{
> + /*
> + * The "early" is only to be true when there is AMD
> + * numa support. Hyper-V AMD SEV-SNP guest may not
> + * have numa support. To make sure smp config is
> + * always initialized, do that when early is false.
> + */
I didn't really understand this comment. After doing a little research, let
me suggest this wording:
/*
* The "early" parameter can be true only if old-style AMD
* Opteron NUMA detection is enabled, which should never be
* the case for an SEV-SNP guest. See CONFIG_AMD_NUMA.
* For safety, just do nothing if "early" is true.
*/
Let me know if this new wording makes sense based on your understanding.
Michael
> + if (early)
> + return;
> +
Powered by blists - more mailing lists