linux-kernel - Re: [PATCH v2 net-next] ethtool: ioctl: improve error checking for set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d059e855-3cff-39e7-1fac-c878da93b7e4@broadcom.com>
Date:   Thu, 8 Jun 2023 09:01:46 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org
Cc:     bcm-kernel-feedback-list@...adcom.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Daniil Tatianin <d-tatianin@...dex-team.ru>,
        Ido Schimmel <idosch@...dia.com>,
        Marco Bonelli <marco@...eim.net>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jiri Pirko <jiri@...nulli.us>, Gal Pressman <gal@...dia.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] ethtool: ioctl: improve error checking for
 set_wol



On 6/7/2023 4:14 PM, Justin Chen wrote:
> The netlink version of set_wol checks for not supported wolopts and avoids
> setting wol when the correct wolopt is already set. If we do the same with
> the ioctl version then we can remove these checks from the driver layer.
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)