[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023060931-magazine-nickname-f386@gregkh>
Date: Fri, 9 Jun 2023 15:10:48 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jeff Layton <jlayton@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>,
Al Viro <viro@...iv.linux.org.uk>,
Brad Warrum <bwarrum@...ux.ibm.com>,
Ritu Agarwal <rituagar@...ux.ibm.com>,
Arnd Bergmann <arnd@...db.de>, Ian Kent <raven@...maw.net>,
"Tigran A. Aivazian" <aivazian.tigran@...il.com>,
Jeremy Kerr <jk@...abs.org>, Ard Biesheuvel <ardb@...nel.org>,
Namjae Jeon <linkinjeon@...nel.org>,
Sungjong Seo <sj1557.seo@...sung.com>,
Bob Peterson <rpeterso@...hat.com>,
Andreas Gruenbacher <agruenba@...hat.com>,
Steve French <sfrench@...ba.org>,
Paulo Alcantara <pc@...guebit.com>,
Ronnie Sahlberg <lsahlber@...hat.com>,
Shyam Prasad N <sprasad@...rosoft.com>,
Tom Talpey <tom@...pey.com>,
John Johansen <john.johansen@...onical.com>,
Paul Moore <paul@...l-moore.com>,
James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
Ruihan Li <lrh2000@....edu.cn>,
Suren Baghdasaryan <surenb@...gle.com>,
Sebastian Reichel <sebastian.reichel@...labora.com>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
autofs@...r.kernel.org, linux-efi@...r.kernel.org,
linux-fsdevel@...r.kernel.org, cluster-devel@...hat.com,
linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org
Subject: Re: [PATCH 0/9] fs: add some missing ctime updates
On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote:
> While working on a patch series to change how we handle the ctime, I
> found a number of places that update the mtime without a corresponding
> ctime update. POSIX requires that when the mtime is updated that the
> ctime also be updated.
>
> Note that these are largely untested other than for compilation, so
> please review carefully. These are a preliminary set for the upcoming
> rework of how we handle the ctime.
>
> None of these seem to be very crucial, but it would be nice if
> various maintainers could pick these up for v6.5. Please let me know if
> you do.
>
> Jeff Layton (9):
> ibmvmc: update ctime in conjunction with mtime on write
> usb: update the ctime as well when updating mtime after an ioctl
> autofs: set ctime as well when mtime changes on a dir
> bfs: update ctime in addition to mtime when adding entries
> efivarfs: update ctime when mtime changes on a write
> exfat: ensure that ctime is updated whenever the mtime is
> gfs2: update ctime when quota is updated
> apparmor: update ctime whenever the mtime changes on an inode
> cifs: update the ctime on a partial page write
>
> drivers/misc/ibmvmc.c | 2 +-
> drivers/usb/core/devio.c | 16 ++++++++--------
> fs/autofs/root.c | 6 +++---
> fs/bfs/dir.c | 2 +-
> fs/efivarfs/file.c | 2 +-
> fs/exfat/namei.c | 8 ++++----
> fs/gfs2/quota.c | 2 +-
> fs/smb/client/file.c | 2 +-
> security/apparmor/apparmorfs.c | 7 +++++--
> security/apparmor/policy_unpack.c | 11 +++++++----
> 10 files changed, 32 insertions(+), 26 deletions(-)
>
> --
> 2.40.1
>
All of these need commit log messages, didn't checkpatch warn you about
that?
thanks,
greg k-h
Powered by blists - more mailing lists