linux-kernel - Re: [PATCH v2] LoongArch: Fix function write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2023 10:04:58 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Qi Hu <huqi@...ngson.cn>
Cc:     WANG Xuerui <kernel@...0n.name>,
        Qing Zhang <zhangqing@...ngson.cn>,
        Enze Li <lienze@...inos.cn>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Miao HAO <haomiao19@...ls.ucas.ac.cn>
Subject: Re: [PATCH v2] LoongArch: Fix function write_fcsr

Queued, thanks.

Huacai

On Thu, Jun 8, 2023 at 10:27 AM Qi Hu <huqi@...ngson.cn> wrote:
>
> Function "write_fcsr" uses wrong asm dest. Fix it!
>
> Reported-by: Miao HAO <haomiao19@...ls.ucas.ac.cn>
> Signed-off-by: Qi Hu <huqi@...ngson.cn>
> ---
>  arch/loongarch/include/asm/loongarch.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/loongarch.h b/arch/loongarch/include/asm/loongarch.h
> index b3323ab5b78d..35e8a52fea11 100644
> --- a/arch/loongarch/include/asm/loongarch.h
> +++ b/arch/loongarch/include/asm/loongarch.h
> @@ -1496,7 +1496,7 @@ __BUILD_CSR_OP(tlbidx)
>  #define write_fcsr(dest, val) \
>  do {   \
>         __asm__ __volatile__(   \
> -       "       movgr2fcsr      %0, "__stringify(dest)" \n"     \
> +       "       movgr2fcsr      "__stringify(dest)", %0 \n"     \
>         : : "r" (val)); \
>  } while (0)
>
> --
> 2.40.1
>