linux-kernel - Re: [PATCH v2 2/4] vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609121244-mutt-send-email-mst@kernel.org>
Date:   Fri, 9 Jun 2023 12:13:15 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Eugenio Pérez <eperezma@...hat.com>
Cc:     Jason Wang <jasowang@...hat.com>,
        Zhu Lingshan <lingshan.zhu@...el.com>,
        virtualization@...ts.linux-foundation.org,
        "Gonglei (Arei)" <arei.gonglei@...wei.com>, longpeng2@...wei.com,
        Lei Yang <leiyang@...hat.com>,
        Parav Pandit <parav@...lanox.com>,
        Gautam Dawar <gdawar@...inx.com>,
        Dragos Tatulea <dtatulea@...dia.com>,
        Laurent Vivier <lvivier@...hat.com>, linux-api@...r.kernel.org,
        Liuxiangdong <liuxiangdong5@...wei.com>,
        linux-kernel@...r.kernel.org, alvaro.karsz@...id-run.com,
        Shannon Nelson <snelson@...sando.io>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Cindy Lu <lulu@...hat.com>, si-wei.liu@...cle.com,
        Harpreet Singh Anand <hanand@...inx.com>
Subject: Re: [PATCH v2 2/4] vdpa: accept
 VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature

On Fri, Jun 09, 2023 at 11:21:25AM +0200, Eugenio Pérez wrote:
> Accepting VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature if
> userland sets it.
> 
> Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> Acked-by: Shannon Nelson <shannon.nelson@....com>

I don't get it, so all vdpa devices accept this automatically?
Should this not be up to the parent?

> ---
>  drivers/vhost/vdpa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index bf77924d5b60..a3204406b73d 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -680,7 +680,8 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
>  			return -EFAULT;
>  		if (features & ~(VHOST_VDPA_BACKEND_FEATURES |
>  				 BIT_ULL(VHOST_BACKEND_F_SUSPEND) |
> -				 BIT_ULL(VHOST_BACKEND_F_RESUME)))
> +				 BIT_ULL(VHOST_BACKEND_F_RESUME) |
> +				 BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK)))
>  			return -EOPNOTSUPP;
>  		if ((features & BIT_ULL(VHOST_BACKEND_F_SUSPEND)) &&
>  		     !vhost_vdpa_can_suspend(v))
> -- 
> 2.31.1